Make deleteAppDataOnUninstall configurable#88
Merged
simonhamp merged 4 commits intoNativePHP:mainfrom Apr 11, 2026
Merged
Conversation
Member
|
Thanks for your PR. I would prefer if it was configurable. This is a breaking change otherwise. |
Add a `nsis.delete_app_data_on_uninstall` option to config/nativephp.php (defaults to false) so app developers can opt in to deleting app data on Windows uninstall without changing the default behavior for existing applications. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
igorgudelj
force-pushed
the
nsis-delete-app-data-on-uninstall
branch
from
ae6fe67 to
1e3f19e
Compare
igorgudelj
changed the title
Contributor
Author
|
Makes sense! I've updated the PR. |
Member
|
We don't need it but it would be great if we could get a test here. We don't need to manually verify that NSIS is deleting the files, just that the flag gets passed through correctly from config to the builder script, as this would help us spot if the config value or.env key get changed by mistake. We can safely assume that Electron Builder's options handle the values correctly given that they follow the spec in their docs |
simonhamp
approved these changes
Mar 4, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
I've added the tests. |
SRWieZ
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nsis.delete_app_data_on_uninstallconfig option (defaults tofalse) so app developers can opt in to deleting%APPDATA%\{appName}on Windows uninstallconfig/nativephp.php→BuildCommandenv var →electron-builder.mjsThe underlying NSIS template already skips deletion during updates (
${ifNot} ${isUpdated}), so app data is preserved when updating to a new version.Usage
In your app's
config/nativephp.php:Or via environment variable:
NATIVEPHP_NSIS_DELETE_APP_DATA=trueTest plan
true%APPDATA%%APPDATA%\{appName}is deletedfalse(default) and verify app data persists after uninstall